-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only run code style analyzers when nullable warnings are enabled #43972
Conversation
Is the impact of this change measurable on a clean build? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment
<When Condition="'$(Language)' == 'VB' and '$(RoslynCheckCodeStyle)' == 'true'"> | ||
<ItemGroup> | ||
<When Condition="'$(Language)' == 'VB'"> | ||
<ItemGroup Condition="'$(RoslynCheckCodeStyle)' == 'true'"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The property this is conditioning on is defined in the targets file now, not the props. Think we should move this <Choose>
to the targets file as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All property groups are evaluated before all item groups. The SDK itself has many examples of cases where default properties are assigned in the targets file (allowing a project file to set values before the defaults are applied as fallback), and items in the props file (allowing a project file to Update
one or more items after the item exists).
Closes #43969